Repair the cache pollution caused by v.tenat != clientConfig.NamespaceId #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #221 +/- ##
==========================================
- Coverage 52.00% 51.88% -0.12%
==========================================
Files 25 25
Lines 1721 1721
==========================================
- Hits 895 893 -2
- Misses 748 749 +1
- Partials 78 79 +1
Continue to review full report at Codecov.
|
binbin0325
reviewed
Apr 26, 2021
| @@ -428,7 +428,7 @@ func longPulling(taskId int) func() error { | |||
| } | |||
| for _, v := range initializationList { | |||
| v.isInitializing = false | |||
| cacheMap.Set(util.GetConfigCacheKey(v.dataId, v.group, clientConfig.NamespaceId), v) | |||
| cacheMap.Set(util.GetConfigCacheKey(v.dataId, v.group, v.tenant), v) | |||
There was a problem hiding this comment.
A better solution might be to use a separate cacheMap for each ConfigClient
There was a problem hiding this comment.
cc1.NamespaceId="namespace1"
client, _ := clients.NewConfigClient(
vo.NacosClientParam{
ClientConfig: cc1,
ServerConfigs: sc,
},
)
// key test-data-1@@test-group@@namespace1
_ = client.ListenConfig(vo.ConfigParam{
DataId: "test-data-1",
Group: "test-group",
OnChange: func(namespace, group, dataId, data string) {
//...
},
})
cc2 := new(constant.ClientConfig)
*cc2 = *cc1
cc2.NamespaceId="2"
client, _ = clients.NewConfigClient(
vo.NacosClientParam{
ClientConfig: cc2,
ServerConfigs: sc,
},
)
// key test-data-2@@test-group@@namespace2
_ = client.ListenConfig(vo.ConfigParam{
DataId: "test-data-2",
Group: "test-group",
OnChange: func(namespace, group, dataId, data string) {
//...
},
})
/*
But cachemap keys may be
[ test-data-1@@test-group@@namespace1,
test-data-2@@test-group@@namespace2,
test-data-2@@test-group@@namespace1, // this is wrong
]
*/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
当使用多个namespceId建立客户端监听配置变化时，在此处clientConfig已经不与v对应，cacheMap.Set会造成的缓存异常。